feat: Add status metric to config #3656
Conversation
Signed-off-by: Avinash Patnala <[email protected]>
Signed-off-by: Avinash Patnala <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3656 +/- ##
==========================================
- Coverage 54.49% 47.82% -6.68%
==========================================
Files 134 222 +88
Lines 12329 18738 +6409
==========================================
+ Hits 6719 8961 +2242
- Misses 5116 8936 +3820
- Partials 494 841 +347
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -93,13 +94,19 @@ func newReconciler(mgr manager.Manager, cm *cm.CacheManager, cs *watch.Controlle | |||
| return nil, fmt.Errorf("cacheManager must be non-nil") | |||
| } | |||
|
|
|||
| r, err := newStatsReporter() | |||
There was a problem hiding this comment.
What are the observability goals for this metric? As in: what kinds of conclusions should consumers be able to draw by observing this metric? Is the data we are expressing sufficient to support those goals?
What are the gaps in reporting present in this current code?
There was a problem hiding this comment.
If GK admin and consumer of metrics are two different users, then I think having number of kinds getting synced in config resource might be helpful when access to config resource is resticted?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #2918
Special notes for your reviewer: